Skip to content

Conversation

@robertwb
Copy link
Contributor

This adapts the Java and Python BigQuery IOs to have the same interface and be callable from Yaml.

Several bugfixes were required along the way to make this work smoothly which are divided out in the commit history.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb
Copy link
Contributor Author

R: @Polber

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #28169 (63c16bb) into master (45ea758) will increase coverage by 0.05%.
Report is 126 commits behind head on master.
The diff coverage is 47.79%.

@@            Coverage Diff             @@
##           master   #28169      +/-   ##
==========================================
+ Coverage   72.30%   72.36%   +0.05%     
==========================================
  Files         678      680       +2     
  Lines       99853   100398     +545     
==========================================
+ Hits        72197    72650     +453     
- Misses      26077    26169      +92     
  Partials     1579     1579              
Flag Coverage Δ
python 82.87% <47.79%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/yaml/main.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/io/gcp/bigquery.py 69.54% <17.24%> (-0.84%) ⬇️
sdks/python/apache_beam/yaml/yaml_io.py 45.45% <45.45%> (ø)
sdks/python/apache_beam/yaml/yaml_provider.py 70.64% <46.15%> (+0.67%) ⬆️
sdks/python/apache_beam/pipeline.py 91.86% <50.00%> (-0.27%) ⬇️
sdks/python/apache_beam/yaml/yaml_transform.py 89.91% <50.00%> (-0.03%) ⬇️
sdks/python/apache_beam/transforms/external.py 74.36% <70.73%> (-0.23%) ⬇️
...ks/python/apache_beam/typehints/schema_registry.py 96.15% <100.00%> (+0.91%) ⬆️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Use the schema provided, rather than just re-ordering.
* Allow for unspecified optional fields.
* Allow skipping of external transforms with unparsable (e.g. language-specific) schemas.
This allows one to remap configs for a cosistant API across languages
(including differences like camelCase vs. snake_case).
This can be invoked from either Python or Java.
type: beamJar
transforms:
'ReadFromBigQuery': 'beam:schematransform:org.apache.beam:bigquery_storage_read:v1'
'WriteToBigQuery': 'beam:schematransform:org.apache.beam:bigquery_storage_write:v1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be v2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. (I changed this at the last minute just to be safe...)

@robertwb
Copy link
Contributor Author

robertwb commented Sep 8, 2023

Java_Examples_Dataflow_Java17 PreCommit

@robertwb
Copy link
Contributor Author

robertwb commented Sep 8, 2023

Run Python_Integration PreCommit

@robertwb
Copy link
Contributor Author

robertwb commented Sep 8, 2023

Python failures are timeout flakes seen elsewhere, Java failures also unrelated (only java change is BQ write provider, which is unused in WordCount).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants