-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix a bug that maxConnections is Short in config but read back as Integer #28174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @bvolpato for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@Abacn Can you please take a look? You have more context here. I can see that |
|
By the way, thanks for contributing @olalamichelle! I'm pinging Yi as he has a lot of context around this provider |
|
There's a check failing for Spotless, please make sure you run |
|
Done. |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. a previous fix done in #26480 still missing this particular code path (it fixed Python xlang jdbc schemaio but misses java schemaio itself)
Yeah, the bug indicates the usage of |
…eger (apache#28174) * Add a test' * Format --------- Co-authored-by: Fei Xie <feixie@MacBook-Pro.attlocal.net>
Also added Unit Tests.