[BEAM-22] Explicitly use a ConcurrentLinkedQueue in UnboundedReadEvaluatorFactory #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @dhalperi |
Contributor
|
Can you say more about why? Is there a test that can add? |
tgroh
force-pushed
the
unbounded_evaluator_close_before_requeue
branch
from
e6ba15d to
febc608
Compare
tgroh
changed the title
tgroh
force-pushed
the
unbounded_evaluator_close_before_requeue
branch
from
febc608 to
263f436
Compare
Member
Author
|
Updated the description; changed what's actually being implemented. There must be a visibility restriction between uses of the evaluators - as an evaluator may be used by different threads, any update to the state of that evaluator must be visible between uses. ConcurrentLinkedQueue provides a happens-before relationship between offering an element to the queue and polling it from that queue. As we offer the evaluator to the queue after completing any updates to the evaluator state, this ensures that reads to the value of CheckpointMark are consistent with the writes to that value. |
tgroh
force-pushed
the
unbounded_evaluator_close_before_requeue
branch
from
263f436 to
05f8d88
Compare
Contributor
|
LGTM |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
PEP 484 specifies that they be hinted as the type of a single element, as seen from the caller's perspective. Closes apache#289. Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
The evaluator may be reused in a different thread, and updates to the
checkpoint must be visible.