fix ConcurrentModificationException in KafkaIO #290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle a possible race between poll thread and close().
rangadi
changed the title
Contributor
Author
| && offsetFetcherThread.awaitTermination(10, TimeUnit.SECONDS)) { | ||
| break; // done | ||
| } | ||
| } catch (InterruptedException e) { |
Contributor
There was a problem hiding this comment.
should you set the interrupted bit here?
Contributor
Author
There was a problem hiding this comment.
I set the flag in two places where we are interrupted on thread not in our control.
Contributor
LGTM once box is checked and tests pass. If you've done both and I haven't merged, ping me ;) |
Contributor
Author
|
R: @dhalperi , I could reproduce this by adding an extra cosumer.poll() after 'closed' flag was seen in consumerPollLoop(). I could not reproduce the problem without extra poll. With that, verified both that the fix works and in case the thread takes much longer, close() properly waits for it to shutdown with periodic warning log. Raghu. |
Contributor
|
LGTM, will merge soon. |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Adds a system test demonstrating that ArrayUnion operation no longer deletes pre-existing data Fixes apache#14 🦕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.