Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Nov 2, 2023

master PR: #29255

Supercedes #29260


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

damccorm commented Nov 2, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-2.52.0@6ca96b5). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2.52.0   #29263   +/-   ##
=================================================
  Coverage                  ?   38.28%           
=================================================
  Files                     ?      689           
  Lines                     ?   101972           
  Branches                  ?        0           
=================================================
  Hits                      ?    39043           
  Misses                    ?    61349           
  Partials                  ?     1580           
Flag Coverage Δ
python 29.89% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 71e9895 into release-2.52.0 Nov 2, 2023
@damccorm damccorm deleted the users/damccorm/protobuf_cp branch November 2, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants