-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-254] Add apache-rat-plugin execution and fix files with missing… #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -219,8 +219,49 @@ | |
| </execution> | ||
| </executions> | ||
| </plugin> | ||
|
|
||
| <plugin> | ||
| <groupId>org.apache.rat</groupId> | ||
| <artifactId>apache-rat-plugin</artifactId> | ||
| <version>0.11</version> | ||
| <executions> | ||
| <execution> | ||
| <phase>verify</phase> | ||
| <goals> | ||
| <goal>check</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| <configuration> | ||
| <reportFile>${project.build.directory}/${project.build.finalName}.rat</reportFile> | ||
| <excludeSubProjects>false</excludeSubProjects> | ||
| <useDefaultExcludes>true</useDefaultExcludes> | ||
| <excludes> | ||
| <!-- Keep exclude sync with .gitignore --> | ||
| <exclude>**/target/**/*</exclude> | ||
| <exclude>**/dependency-reduced-pom.xml</exclude> | ||
| <exclude>**/*.iml</exclude> | ||
| <exclude>**/package-list</exclude> | ||
| <exclude>**/user.avsc</exclude> | ||
| <exclude>**/test/resources/**/*.txt</exclude> | ||
| <exclude>**/test/**/.placeholder</exclude> | ||
| <exclude>.repository/**/*</exclude> | ||
| </excludes> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> | ||
|
|
||
| <plugins> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. empty line between pluginManagement and plugins sections?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 |
||
| <plugin> | ||
| <groupId>org.apache.rat</groupId> | ||
| <artifactId>apache-rat-plugin</artifactId> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-assembly-plugin</artifactId> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </profile> | ||
|
|
||
|
|
@@ -233,6 +274,7 @@ | |
| <dataflow.javadoc_opts>-Xdoclint:-missing</dataflow.javadoc_opts> | ||
| </properties> | ||
| </profile> | ||
|
|
||
| </profiles> | ||
|
|
||
| <dependencyManagement> | ||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,29 @@ | ||
| ## Protocol Buffers in Google Cloud Dataflow | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| This directory contains the Protocol Buffer messages used in Google Cloud | ||
| Dataflow. | ||
|
|
||
| ## Protocol Buffers in Apache Beam | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be Google Dataflow specific, based on the below maven artifact reference.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So, does it mean that it should be removed from the Apache repo ?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like the only thing here (proto2_coder_test_messages.proto) is for testing. If that's the case, I would suggest updating the verbage of this README with the test details and removing dataflow-specific bits. At any rate, it might be easier to save for a separate PR as to not hold up this one. Adding a few people that might know more: @dhalperi @kennknowles
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have a few options forward here, but yes I think that this can wait for another PR. Right now we have not yet re-deployed the proto jar under
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jbonofre : this is needed for testing |
||
|
|
||
| This directory contains the Protocol Buffer messages used in Apache Beam. | ||
|
|
||
| They aren't, however, used during the Maven build process, and are included here | ||
| for completeness only. Instead, the following artifact on Maven Central contains | ||
| the binary version of the generated code from these Protocol Buffers: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these comments show up in the github pull request description field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's hidden in github (markdown).