-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[flink] Fix watermark generation for empty UnboundedSource #30066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a05755 to
5865037
Compare
|
Run Flink ValidatesRunner |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
lgtm |
|
Run Flink ValidatesRunner |
|
Hi, we have migrated to GitHub Action and the way to run PostCommit has changed due to some limitation of GHA. To run Flink ValidatesRunner PostCommit, add an empty file named |
|
Ah, thanks. |
|
though the Jenkins is still running a few job (with only a couple of workers) For this PR, the result is in https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_PR/511/ |
|
testTeardownCalledAfterExceptionInStartBundleStateful is a known flaky test: #19814 |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #30050
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.