Skip to content

Conversation

@je-ik
Copy link
Contributor

@je-ik je-ik commented Jan 22, 2024

Closes #30050


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@je-ik je-ik force-pushed the 30050-fix-empty-reader-watermark branch from 5a05755 to 5865037 Compare January 22, 2024 16:37
@je-ik je-ik changed the title [runner-flink] Fix watermark generation for empty UnboundedSource [flink] Fix watermark generation for empty UnboundedSource Jan 22, 2024
@je-ik
Copy link
Contributor Author

je-ik commented Jan 22, 2024

R: @Abacn @JozoVilcek @dmvk

@je-ik
Copy link
Contributor Author

je-ik commented Jan 22, 2024

Run Flink ValidatesRunner

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@JozoVilcek
Copy link
Contributor

lgtm

@je-ik
Copy link
Contributor Author

je-ik commented Jan 23, 2024

Run Flink ValidatesRunner

@je-ik je-ik added the P1 label Jan 23, 2024
@je-ik je-ik added this to the 2.54.0 Release milestone Jan 23, 2024
@Abacn
Copy link
Contributor

Abacn commented Jan 23, 2024

Hi, we have migrated to GitHub Action and the way to run PostCommit has changed due to some limitation of GHA. To run Flink ValidatesRunner PostCommit, add an empty file named .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Flink.json and attach to your PR, see https://github.com/apache/beam/tree/master/.github/workflows#comment-triggering-support

@je-ik
Copy link
Contributor Author

je-ik commented Jan 23, 2024

Ah, thanks.

@Abacn
Copy link
Contributor

Abacn commented Jan 23, 2024

though the Jenkins is still running a few job (with only a couple of workers)

For this PR, the result is in https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_PR/511/

@Abacn
Copy link
Contributor

Abacn commented Jan 23, 2024

testTeardownCalledAfterExceptionInStartBundleStateful is a known flaky test: #19814

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@je-ik je-ik merged commit 90e7c9e into apache:master Jan 23, 2024
@je-ik je-ik deleted the 30050-fix-empty-reader-watermark branch January 23, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: FlinkRunner: KafkaIO emits MAX_WATEMARK

3 participants