Skip to content

Conversation

@ahmedabu98
Copy link
Contributor

@ahmedabu98 ahmedabu98 commented Mar 29, 2024

Managed transforms API for Java

Fixes #30830

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is pretty close to what we want IMO.

cc: @robertwb @kennknowles

@chamikaramj
Copy link
Contributor

Let's also add unit-testing using existing SchemaTransforms (we'll have to mock/override the set of transforms for a group or the pattern used to select the set of transforms for a group).

@ahmedabu98 ahmedabu98 marked this pull request as ready for review April 2, 2024 19:33
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98 ahmedabu98 added this to the 2.56.0 Release milestone Apr 4, 2024
Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chamikaramj
Copy link
Contributor

Also, please fix spotless/lint failures.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.34%. Comparing base (ffc96bc) to head (5ef97a9).
Report is 62 commits behind head on master.

❗ Current head 5ef97a9 differs from pull request most recent head 7d527e2. Consider uploading reports for the commit 7d527e2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #30808      +/-   ##
============================================
- Coverage     61.25%   60.34%   -0.92%     
+ Complexity     4470     2987    -1483     
============================================
  Files           853      659     -194     
  Lines         74090    65994    -8096     
  Branches       4307     3231    -1076     
============================================
- Hits          45385    39823    -5562     
+ Misses        25224    23078    -2146     
+ Partials       3481     3093     -388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

This looks great!

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@ahmedabu98 ahmedabu98 merged commit 5467399 into apache:master Apr 8, 2024
@ahmedabu98 ahmedabu98 changed the title [Java] ManagedIO [Java] Managed API Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Managed transforms Java API

4 participants