Skip to content

Conversation

@je-ik
Copy link
Contributor

@je-ik je-ik commented Apr 16, 2024

Removes Flink runner 1.12 and 1.13 after 1.17 will be merged.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@je-ik
Copy link
Contributor Author

je-ik commented Apr 16, 2024

R: @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@je-ik je-ik mentioned this pull request Apr 16, 2024
3 tasks
@je-ik je-ik force-pushed the remove-flink-1.12-1.13 branch from 73e56ad to 7f97906 Compare April 16, 2024 13:18
@je-ik je-ik force-pushed the remove-flink-1.12-1.13 branch from 7f97906 to e4baee6 Compare April 17, 2024 15:41
@je-ik
Copy link
Contributor Author

je-ik commented Apr 17, 2024

Marking this as blocker for 2.56.0, this should be trivial to merge.

@je-ik je-ik added this to the 2.56.0 Release milestone Apr 17, 2024
@je-ik je-ik force-pushed the remove-flink-1.12-1.13 branch from 7c8e5d7 to e4baee6 Compare April 17, 2024 16:29
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Abacn
Copy link
Contributor

Abacn commented Apr 17, 2024

Java PreCommit failing test

testExampleEchoPipeline (org.apache.beam.examples.subprocess.ExampleEchoPipelineTest) failed

org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.Exception: java.io.IOException: Cannot run program "/tmp/test-Echoo1141159604754263537/test-EchoAgain8445332997975022285.sh": error=26, Text file busy
	at org.apache.beam.runners.direct.DirectRunner$DirectPipelineResult.waitUntilFinish(DirectRunner.java:377)
...
Caused by: java.io.IOException: error=26, Text file busy
	at java.lang.UNIXProcess.forkAndExec(Native Method)

test not related to Flink runner, looks like a racing condition.

@Abacn
Copy link
Contributor

Abacn commented Apr 17, 2024

Also please open another PR to update CHANGES.md (changing on this PR will cause many test rerun)

@je-ik je-ik merged commit 3cfc160 into apache:master Apr 17, 2024
@je-ik je-ik deleted the remove-flink-1.12-1.13 branch April 17, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants