Remove caching of global window side input param when invoking. #30991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Addresses #28776 |
Instead rely on the higher-level cache which utilizes the side input cache tokens allowing the runner to determine the caching used for side inputs.
scwhittle
force-pushed
the
global_data_cache
branch
from
eb4d337 to
4913682
Compare
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
riteshghorse
approved these changes
Apr 16, 2024
Contributor
riteshghorse
left a comment
riteshghorse
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
CC: @AnandInguva
3 tasks
tvalentyn
reviewed
Apr 17, 2024
|
|
||
| kwargs_for_process_batch = kwargs_for_process_batch or {} | ||
|
|
||
| if additional_kwargs: |
Contributor
There was a problem hiding this comment.
Is this a drive-by change or is it directly related to the intention of this PR?
tvalentyn
reviewed
Apr 18, 2024
| # windowed inputs when processing the first element. | ||
| self.cache_globally_windowed_args = False | ||
|
|
||
| # Fill in sideInputs if they are globally windowed |
Contributor
There was a problem hiding this comment.
Is my understanding correct that the fundamental flaw in this logic is that even for a global window, the sideinput can refresh if a window has a trigger configured?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead rely on the higher-level cache which utilizes the side input cache tokens allowing the runner to determine the caching used for side inputs.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.