-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[#30941]fix upgrade test due to missed config ConsumerPollingTimeout #30998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…meout in KafkaIOTranslation
…meout in KafkaIOTranslation
.../io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java
Outdated
Show resolved
Hide resolved
…meout in KafkaIOTranslation
.../io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java
Outdated
Show resolved
Hide resolved
…meout in KafkaIOTranslation
…meout in KafkaIOTranslation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I'm going to go ahead and merge so this is part of the release cut.
@chamikaramj @Abacn I'd appreciate an extra pass from both of you to validate correctness, if anything comes up in that review we can address with a follow-on PR (and cherry-pick if needed)
addess #30941: fix upgrade test due to missed config ConsumerPollingTimeout in KafkaIOTranslation