Skip to content

Conversation

@xianhualiu
Copy link
Contributor

addess #30941: fix upgrade test due to missed config ConsumerPollingTimeout in KafkaIOTranslation

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @kennknowles for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'm going to go ahead and merge so this is part of the release cut.

@chamikaramj @Abacn I'd appreciate an extra pass from both of you to validate correctness, if anything comes up in that review we can address with a follow-on PR (and cherry-pick if needed)

@damccorm damccorm merged commit 8092932 into apache:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants