Fix internal test failure caused by PR 31550 #31602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
R: @damccorm |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
damccorm
approved these changes
Jun 14, 2024
Contributor
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Thanks! We should probably cherry-pick this since it catches the additional soft delete cases
cc/ @kennknowles
Contributor
|
I'll merge after checks complete |
shunping
added a commit
to shunping/beam
that referenced
this pull request
Jun 14, 2024
3 tasks
kennknowles
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed a few timeout failures in our internal test suite. This PR will fix the timeouts by setting a deadline for the request. It will also fix a missing scenario where we need to check whether to fire the warning.