-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[#32115] Fix timer support, support timer clears. #32119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32119 +/- ##
=========================================
Coverage 58.68% 58.68%
Complexity 3025 3025
=========================================
Files 1122 1122
Lines 172906 172923 +17
Branches 3285 3285
=========================================
+ Hits 101463 101476 +13
- Misses 68131 68134 +3
- Partials 3312 3313 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
damondouglas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I didn't understand what a lot of this code was doing. From a reviewer perspective, I'm approving to unblock given there is at least a testing coverage somewhere.
Allows a few of the Python timer based tests to pass.
TODO for a different test: Support interval and custom window functions for timers.
Fixes #32115
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.