Skip to content

Conversation

@damondouglas
Copy link
Contributor

This PR closes #31967, closes #31935, and closes #31935 with a Java Prism Runner.

  • Resolves, downloads and executes Prism via PrismLocator/Executor
  • Wraps PipelineResult methods delegating to the portability module's JobServicePipelineResult

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas
Copy link
Contributor Author

R: @lostluck

@damondouglas damondouglas marked this pull request as ready for review August 23, 2024 00:05
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor 1 requested change WRT the idle_shutdown_flag in PrismRunner.
(the others are commentary).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is supposed to be in test code, but it feels weird to have/use a hamcrest assert in production instead of the AssertionError that other things expect?

We can resolve that later as we become more comfortable with the Java test stack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this is what TestDataflowRunner and the TestPortableRunner do, so it's fine for now.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular! Thanks!

I'll merge once checks pass.

@lostluck lostluck merged commit b8bbf59 into apache:master Aug 23, 2024
@damondouglas damondouglas deleted the prism-final-v2 branch September 25, 2024 19:41
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task][Prism]: Create a PrismRunnerRegistrar [Task][Prism]: Create a PipelineResult implementation

2 participants