-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Improve Datastream for batch performances #32373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Flink] fix lazy enumerator package
[Flink] Implement partial reduce [Flink] dead code cleanup [Flink] spotless [Flink] persistent PartialReduceBundleOperator operator state
* spotless * checkstyle * spotless
6d7e1e8 to
32a311e
Compare
32a311e to
b672504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Flink will drop support for the dataset API in 2.0 which should be released by EOY so it quite important for Beam to support Datastream well.
The PR
This PR improves the performances of Batch jobs executed with
--useDatastreamForBatchby porting the following performance optimizations already present inFlinkBatchTransformTranslatorsbut lacking inFlinkStreamingTransformTranslators.It also implements the following optimizations:
maxParallelismtoparallelismas the total number of splits is equal tomaxParallelism. Again this reduces skew.ToKeyedWorkItempart ofDoFnOperatorwhich reduces the size of the job graph and avoid unnecessary inter-task communication.GBK -> map -> CombinePerKey). Add a flag to control this feature (defaults to active).Benchmarks
The patched version was tested against a few of Spotify's production batch workflows. All settings were left unchanged except for the followings:
--useDatastreamForBatch=truejobmanager.scheduler: default(otherwise datastream default to adaptive scheduler).Note
Job 3 fails with a stackoverflow exception because if a bug in old version of Kryo. I believe this is because the job uses
taskmanager.runtime.large-record-handler: trueand it should be fixed in Flink 2.0 since Kryo is upgraded to a more recent version.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.