[Dataflow Streaming] Move throwExceptionOnLargeOutput out of OperationalLimits
#32407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionalLimits Planning to move OperationslLimits along with other settings from backend into a common class. `throwExceptionOnLargeOutput` is calculated from PipelineOptions, moving it out of OperationalLimits to avoid making the new classes depend on PipelineOptions.
Contributor
Author
|
R: @scwhittle |
Contributor
Author
|
cc: @acrites |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning to move OperationslLimits along with other settings from backend into a common class.
throwExceptionOnLargeOutputis calculated from PipelineOptions, moving it out of OperationalLimits to avoid making the new classes depend on PipelineOptions.