[WIP] Upgrade version of io.debezium #33526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
damccorm
commented
Jan 7, 2025
| */ | ||
| package org.apache.beam.sdk.io.gcp.pubsub; | ||
|
|
||
| import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument; |
Contributor
Author
There was a problem hiding this comment.
This isn't used in this file and keeps getting removed by my linter, including it here.
Contributor
Author
|
Closing in favor of #33541 |
Contributor
|
@damccorm do you still have the code of your branch somewhere? Debezium seems to have upgraded protoc to 1.5 now in Release 3.1 -> https://issues.redhat.com/browse/DBZ-8670 (https://debezium.io/releases/3.1/release-notes) |
tkaymak
added a commit
to tkaymak/beam
that referenced
this pull request
Apr 24, 2025
3 tasks
tkaymak
added a commit
to tkaymak/beam
that referenced
this pull request
Apr 25, 2025
tkaymak
added a commit
to tkaymak/beam
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of responding to protobuf upgrade
Given I'm now including antlr, I'm trying to run Java PreCommit as well - https://github.com/apache/beam/actions/runs/12677490690 - since antlr broke this before - #33028
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.