Skip to content

Conversation

@ahmedabu98
Copy link
Contributor

Cherry picking #33231

…m writers (apache#33231)

* add dynamic dest test

* fix and add some tests

* add to changes.md

* fix whitespace

* trigger postcommits

* address comments
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when green.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98
Copy link
Contributor Author

unrelated test failure:

org.apache.beam.sdk.io.gcp.spanner.SpannerReadIT > testReadFailsBadSession FAILED
    java.util.concurrent.ExecutionException at SpannerReadIT.java:166
        Caused by: com.google.cloud.spanner.SpannerException at SpannerExceptionFactory.java:309
            Caused by: io.grpc.StatusRuntimeException at Status.java:532

170 tests completed, 1 failed, 31 skipped

@kennknowles
Copy link
Member

Hmm yea and took 4 hours. That test suite needs to be broken up, unless it was a crashloop.

@kennknowles
Copy link
Member

I'm going to take the chance and merge to build RC1 but can you dig in to the test failure a tiny bit to see what is going on? And maybe we try to separate the tests for the various IOs even though they are in one module.

@kennknowles kennknowles merged commit 48e18c4 into apache:release-2.62.0 Jan 9, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants