-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix incorrect nullness in FlinkJobInvoker and JobInvoker #33713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
|
|
Hi @robertwb, please review when you have a chance. Thanks! |
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb added as fallback since no labels match configuration Available commands:
|
|
R: @je-ik |
|
I don't have time that I thought I would have to work on FlinkRunner right now, but I figure might as well get this tiny improvement checked in. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
je-ik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Revert PR #33713 * Run SpotlessJavaApply
Note that this is an actual error not just a hardening of the codebase: the
retrievalTokenis marked as required in the proto.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.