[BEAM-117] Add labels for SDK display data #338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swegner
changed the title
Contributor
Author
|
R: @bjchambers |
| .withLabel("Output File Suffix"), | ||
| "") | ||
| .addIfNotDefault(DisplayData.item("numShards", numShards) | ||
| .withLabel("Maximum Shard Count"), |
Contributor
There was a problem hiding this comment.
"Maximum output shards"?
Contributor
|
A few comments, then LGTM once tests pass. |
swegner
force-pushed
the
displaydata-labels
branch
from
bbe2026 to
472dd41
Compare
Contributor
Author
|
tests are green, @bjchambers ready to merge |
Contributor
Author
|
Backport: GoogleCloudPlatform/DataflowJavaSDK#230 |
dhalperi
pushed a commit
to dhalperi/beam
that referenced
this pull request
Aug 23, 2016
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.