Skip to content

Add UnboundedReadFromBoundedSource, and use it in Dataflow runner #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peihe wants to merge 11 commits into from
Closed

Add UnboundedReadFromBoundedSource, and use it in Dataflow runner #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0544b51
Add toUnbounded() to get a Unbounded Read from a Bounded Read.
peihe May 9, 2016
de01db2
fixup: addressed feedback
peihe May 16, 2016
0f7ab0b
fixup: addressed feedback
peihe May 18, 2016
e4ccde1
fixup: addressed feedback
peihe May 18, 2016
9cc3412
addressed comments
peihe Jun 10, 2016
120d4c7
addressed comments
peihe Jun 10, 2016
2908b4a
test unsplittable source and refactor the Reader code
peihe Jun 14, 2016
44b595d
Addressed comments
peihe Jun 17, 2016
91527cd
addressed comments
peihe Jun 23, 2016
46abb90
fix checkstyle and build
peihe Jun 23, 2016
847421a
Revert Dataflow runner changes
peihe Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions runners/core-java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,31 @@
<artifactId>beam-sdks-java-core</artifactId>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>

<dependency>
<groupId>joda-time</groupId>
<artifactId>joda-time</artifactId>
</dependency>

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Copy link
Contributor

@dhalperi dhalperi Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add shading, too

Copy link
Contributor Author

@peihe peihe Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is guava already shaded in line 123?

Copy link
Contributor

@dhalperi dhalperi Jun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Hah -- we were shading it without using it?

</dependency>

<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</dependency>

<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>

<!-- build dependencies -->

<dependency>
Expand Down
Loading