Fix Java GCP-IO Direct job #34019
Merged
Fix Java GCP-IO Direct job #34019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
R: @ahmedabu98 |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Abacn
reviewed
Feb 19, 2025
| @Mock private Counter mockCounter; | ||
| private final Sleeper mockSleeper = | ||
| millis -> { | ||
| verify(mockCounter).inc(millis); |
Contributor
There was a problem hiding this comment.
would you mind explaining a little bit how this fixed the flaky test
Collaborator
Author
There was a problem hiding this comment.
verify expected exactly one call, but sometimes the code retries and calls inc(millis) multiple times causing the test to fail.
Abacn
reviewed
Feb 19, 2025
...platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java
Show resolved
Hide resolved
Abacn
approved these changes
Feb 19, 2025
Contributor
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
Thank you! These are all long-standing flaky tests
ahmedabu98
requested changes
Feb 19, 2025
Contributor
ahmedabu98
left a comment
ahmedabu98
left a comment
There was a problem hiding this comment.
thanks @akashorabek, LGTM except for one suggestion
...platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java
Show resolved
Hide resolved
Fix java gcp io direct job
Abacn
approved these changes
Feb 24, 2025
17 tasks
VardhanThigle
pushed a commit
to VardhanThigle/beam
that referenced
this pull request
Mar 21, 2025
* Fix Java GCP-IO Direct job * Created constants for fixed numbers * Fix comments and constants * Changed Log type * add more flaky test fixes * changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33909
Successful run example: https://github.com/akashorabek/beam/actions/runs/13397067650
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.