Skip to content

Conversation

@lostluck
Copy link
Contributor

Adds a missing line when handling alias types. It's important to also register types and imports even if that type is an alias, so, the generated files won't drop the types. Necessary for support on Go 1.24+, when the register package isn't being used.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the go label Feb 20, 2025
@lostluck
Copy link
Contributor Author

R: @jrmccluskey

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck
Copy link
Contributor Author

Thanks! Will merge once the checks are done.

@lostluck lostluck merged commit 8625199 into apache:master Feb 20, 2025
6 checks passed
@lianliangzhang
Copy link

lianliangzhang commented Feb 21, 2025 via email

@lostluck lostluck deleted the aliasFix branch February 21, 2025 15:55
@lostluck
Copy link
Contributor Author

@lianliangzhang I'm not the right person for this these days.
Sorry you're experiencing an issue.

You should either file a support issue with Google Cloud Dataflow (which is where those messages are coming from), or email user@beam.apache.org to get the right people's attention.

In the absolute last case, you should file a GitHub issue here. Generally do not jump on unrelated PRs.

VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
Abacn added a commit that referenced this pull request Mar 27, 2025
#34024)

* #34009 avro generic record to beam row conversion added support for all logical types and conversions

* using string comparison to avoid class not found issues with earlier versions of avro

* using string comparison to avoid class not found issues with earlier versions of avro

* com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1

* using string comparison to avoid class not found issues with earlier versions of avro

* com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1

* Add `types.Unalias` to types assertions and types switches to get an underlying type instead of types.Alias (#33868)

* Revert huggingface transformers to 4.30.0 (#34025)

* add endpoint type to WorkerMetadataResponse proto (#33953)

* add endpoint type to WorkerMetadataResponse proto

* add default value to endpoint_type

* add hashcode/equals to WaitTest helper classes to avoid log error (#34006)

* Add enable_lineage experiment to Dataflow tests (#34027)

* Add UUID support in SpannerSchema (#34034)

* Add UUID support in Spanner Schema

* Add test

* fix dashboard link (#34023)

* [Go SDK] Add missing type inspection case for Alias types. (#34039)

* removed unneeded license header

* remove unneeded license header

* Added tests for specific records generated with avro 1.8.2 and 1.9.2, and to add custom conversions

* Supporting different UUID representations in different avro versions

* Spotless fixes

* fix dependency typo

---------

Co-authored-by: Alfredo Scaccialepre <alfredo.scaccialepre@edreamsodigeo.com>
Co-authored-by: synenka <97878236+synenka@users.noreply.github.com>
Co-authored-by: Vitaly Terentyev <vitaly.terentyev@akvelon.com>
Co-authored-by: martin trieu <martinkt@google.com>
Co-authored-by: scwhittle <scwhittle@users.noreply.github.com>
Co-authored-by: Yi Hu <yathu@google.com>
Co-authored-by: Luv Agarwal <luvagarwal.k@gmail.com>
Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
liferoad pushed a commit to liferoad/beam that referenced this pull request Apr 4, 2025
… for a… (apache#34024)

* apache#34009 avro generic record to beam row conversion added support for all logical types and conversions

* using string comparison to avoid class not found issues with earlier versions of avro

* using string comparison to avoid class not found issues with earlier versions of avro

* com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1

* using string comparison to avoid class not found issues with earlier versions of avro

* com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1

* Add `types.Unalias` to types assertions and types switches to get an underlying type instead of types.Alias (apache#33868)

* Revert huggingface transformers to 4.30.0 (apache#34025)

* add endpoint type to WorkerMetadataResponse proto (apache#33953)

* add endpoint type to WorkerMetadataResponse proto

* add default value to endpoint_type

* add hashcode/equals to WaitTest helper classes to avoid log error (apache#34006)

* Add enable_lineage experiment to Dataflow tests (apache#34027)

* Add UUID support in SpannerSchema (apache#34034)

* Add UUID support in Spanner Schema

* Add test

* fix dashboard link (apache#34023)

* [Go SDK] Add missing type inspection case for Alias types. (apache#34039)

* removed unneeded license header

* remove unneeded license header

* Added tests for specific records generated with avro 1.8.2 and 1.9.2, and to add custom conversions

* Supporting different UUID representations in different avro versions

* Spotless fixes

* fix dependency typo

---------

Co-authored-by: Alfredo Scaccialepre <alfredo.scaccialepre@edreamsodigeo.com>
Co-authored-by: synenka <97878236+synenka@users.noreply.github.com>
Co-authored-by: Vitaly Terentyev <vitaly.terentyev@akvelon.com>
Co-authored-by: martin trieu <martinkt@google.com>
Co-authored-by: scwhittle <scwhittle@users.noreply.github.com>
Co-authored-by: Yi Hu <yathu@google.com>
Co-authored-by: Luv Agarwal <luvagarwal.k@gmail.com>
Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants