-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Bump to Mokito 4 #34054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Mokito 4 #34054
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
* Split tests need mockStatic outside of DataflowTest To be able to run DataflowTest internally which did not support mockStatic * Remove usage of powermock for GcpIO, KafkaIO, DataflowRunner tests * Minimize powermock dependency for Flink runner
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
PreCommit Flink Container passed, failed at tearDown dataproc, infra flakiness |
|
testOnNewWorkerMetadata_redistributesBudget failed twice due to #28957. Test succeeded locally. not related to this change |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Split tests need mockStatic outside of DataflowTest To be able to run DataflowTest internally which did not support mockStatic * Remove usage of powermock for GcpIO, KafkaIO, DataflowRunner tests * Minimize powermock dependency for Flink runner
Part of #34056 . Powermock is not compatible with Mockito 4, had to remove its usage in most tests, if applicable
Split tests need mockStatic outside of DataflowTest
To be able to run DataflowTest internally which did not support mockStatic
Remove usage of powermock for GcpIO, KafkaIO, DataflowRunner tests
Minimize powermock dependency for Flink runner
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.