-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix race condition #34058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition #34058
Conversation
…mccorm/jdbcPatch
|
Launching some performance tests to see if this change has any impact: https://github.com/apache/beam/actions/runs/13592236722 I'm hopeful it won't since:
|
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
Outdated
Show resolved
Hide resolved
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Shall we call this out in CHANGES.md? |
Sure, #34147 |
* Update JdbcIO.java * Fix vars * Fix typing problems * Use lineage check so that we maintain safety * Remove dupe assignment * Assign correctly inside lock to avoid race * Add other getConnection * Fix bad merge * Remove unneeded logs * Shrink critical section * Cleanup * Fix bad refactor * typo






It seems that not all Datasources are thread safe when creating connections and can hang when many threads try to create connections at once. Since datasources can be shared across threads, this creates a problem. This pr attempts to resolve the problem, though right now I'm mostly using it to test/validate the fix.
Fixes #34120
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.