Update MongoDB driver to mongodb-driver-legacy:5.4.0 #34100

jyemin · 2025-02-27T14:56:11Z

Upgrade MongoDB Driver to latest available release.

Note that as of 4.0 the mongo-java-driver uber jar is no longer published, so using mongodb-driver-legacy (which will pull in transitive dependencies) in its place.

I'll also note that I wasn't able to build the project locally without errors so I'm using the PR to check whether everything still works.

#32088

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

jyemin · 2025-02-27T14:58:57Z

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

        mockito_core                                : "org.mockito:mockito-core:3.7.7",
        mockito_inline                              : "org.mockito:mockito-inline:4.5.1",
-        mongo_java_driver                           : "org.mongodb:mongo-java-driver:3.12.11",
+        mongo_java_driver                           : "org.mongodb:mongodb-driver-legacy:5.3.1",


To minimize the changes, I left the name of the library as is, but happy to change it to mongodb-driver-legacy if that makes sense.

github-actions · 2025-02-27T15:36:28Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

jyemin · 2025-02-27T18:29:52Z

sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbGridFSIO.java

      private DBCursor createCursor(GridFS gridfs) {
        if (spec.filter() != null) {
-          DBObject query = (DBObject) JSON.parse(spec.filter());
+          DBObject query = BasicDBObject.parse(spec.filter());


The Extended JSON syntax accepted by BasicDBObject#parse is mostly consistent with the syntax accepted by JSON#parse. To understand whether this might cause compatibility issues, can anyone point me to how spec.filter() is initialized? Does the filter come from the application or is it generated by the framework, and if the later, where in the code does that happen?

This reverts commit 1eb32c3.

This reverts commit eb7c1d2.

derrickaw · 2025-03-18T03:23:05Z

assign set of reviewers

github-actions · 2025-03-18T03:24:20Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label build.
R: @johnjcasey for label io.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

jyemin · 2025-03-18T12:42:46Z

Apologies for not being able to get all the checks to pass. Would appreciate some assistance.

Abacn · 2025-03-18T15:28:42Z

The failed test is

org.junit.ComparisonFailure: expected:<{"$match": {"[_id": {"$gt": {"$oid": "52cc8f6254c5317943000005"}}]}}> but was:<{"$match": {"[$and": [{"_id": {"$gt": {"$oid": "52cc8f6254c5317943000005"}}}]]}}>
	at org.junit.Assert.assertEquals(Assert.java:117)

From failed test, go to "Summary", One can see "For more details on these failures, see this check" with a link, then the stack trace for failed test is there.

Also, there is "JUnit Test Results" uploaded in Artifact Section and one can download

github-actions · 2025-03-26T12:14:38Z

Reminder, please take a look at this pr: @robertwb @Abacn @johnjcasey

jyemin · 2025-03-26T16:39:00Z

The 5.4.0 driver was recently released, and I updated the dependency to reflect that. Note that 5.4.0, for the first time, includes a BOM. I'm unsure how to reference the BOM in this project, but perhaps maintainers can advise.

jyemin · 2025-03-26T19:52:01Z

Also unclear why this error is happening:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sdks:java:extensions:sql:analyzeClassesDependencies'.
> Dependency analysis found issues.
  usedUndeclaredArtifacts
   - org.mongodb:bson:5.4.0@jar
   - org.mongodb:mongodb-driver-core:5.4.0@jar
  unusedDeclaredArtifacts
   - org.mongodb:mongodb-driver-legacy:5.4.0@jar

Can anyone advise?

Abacn · 2025-03-26T22:00:43Z

Also unclear why this error is happening:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sdks:java:extensions:sql:analyzeClassesDependencies'.
> Dependency analysis found issues.
  usedUndeclaredArtifacts
   - org.mongodb:bson:5.4.0@jar
   - org.mongodb:mongodb-driver-core:5.4.0@jar
  unusedDeclaredArtifacts
   - org.mongodb:mongodb-driver-legacy:5.4.0@jar

Can anyone advise?

This is a gradle-dependency-analyze check. It suggests in ":sdks:java:extensions:sql" it is still mongodb-driver-core instead of mongodb-driver-legacy are actually used one

jyemin · 2025-04-01T21:08:00Z

@Abacn I tried various combinations of dependencies, but have not been able to find the right combination that works. I would appreciate if someone with more knowledge of the build system could give it a shot, but I understand if this PR is not top of mind for the maintainers.

github-actions · 2025-04-09T12:15:00Z

Reminder, please take a look at this pr: @robertwb @Abacn @johnjcasey

github-actions · 2025-04-14T12:14:51Z

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @damccorm for label build.
R: @johnjcasey for label io.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

damccorm · 2025-04-14T13:06:03Z

R: @Abacn (keeping sticky since Yi has started to review)

github-actions · 2025-04-14T13:07:28Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions · 2025-06-14T12:46:11Z

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

chamikaramj · 2025-06-20T19:57:31Z

@jyemin could you address the error and resolve the conflict so that the review can continue ?

Please let us know if you need additional help.

derrickaw · 2025-08-06T17:51:03Z

waiting on author

github-actions · 2025-10-06T12:47:00Z

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

github-actions · 2025-10-13T12:47:04Z

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Update MongodB driver to mongodb-driver-legacy:5.3.1

5ce5941

github-actions bot added the build label Feb 27, 2025

jyemin changed the title ~~Update MongodB driver to mongodb-driver-legacy:5.3.1~~ Update MongoDB driver to mongodb-driver-legacy:5.3.1 Feb 27, 2025

jyemin commented Feb 27, 2025

View reviewed changes

Remove use of methods no longer available in the MongoDB driver

c11e651

github-actions bot added java io mongodb labels Feb 27, 2025

jyemin added 2 commits February 27, 2025 13:05

Remove unused import

9fe9671

Check for null arguments

967d137

jyemin commented Feb 27, 2025

View reviewed changes

jyemin added 4 commits February 27, 2025 14:45

Handle change to Filters#and

be30c00

Revert last commit

9bc37c0

Debugging

eb7c1d2

Add undeclared transitive dependencies

3ccf806

github-actions bot added extensions sql labels Feb 27, 2025

jyemin added 3 commits February 27, 2025 15:39

Add undeclared transitive dependencies

1eb32c3

Revert "Add undeclared transitive dependencies"

10d93ef

This reverts commit 1eb32c3.

Revert "Debugging"

fd18f62

This reverts commit eb7c1d2.

github-actions bot added the Next Action: Reviewers label Mar 18, 2025

github-actions bot added the slow-review label Mar 26, 2025

jyemin added 2 commits March 26, 2025 12:14

Merge branch 'master' into update-mongodb-driver

f80a71c

Update MongoDB dependency to 5.4.0.

cfabd56

Fixed mockito dependencies

91b650d

jyemin changed the title ~~Update MongoDB driver to mongodb-driver-legacy:5.3.1~~ Update MongoDB driver to mongodb-driver-legacy:5.4.0 Mar 26, 2025

github-actions bot removed the slow-review label Mar 26, 2025

jyemin added 4 commits March 31, 2025 12:22

Update dependency from legacy to core

2ec2639

add bson dependency

4622e6b

add sync dependency

c43ed7c

Update dependencies

5349c15

github-actions bot added the slow-review label Apr 9, 2025

github-actions bot removed the slow-review label Apr 14, 2025

github-actions bot added the stale label Jun 14, 2025

github-actions bot removed the stale label Jun 21, 2025

Abacn mentioned this pull request Aug 26, 2025

feat(mongodb): upgrade MongoDB Java driver to version 5.5.0 #35946

Merged

3 tasks

github-actions bot added the stale label Oct 6, 2025

github-actions bot closed this Oct 13, 2025

Update MongoDB driver to mongodb-driver-legacy:5.4.0 #34100

Update MongoDB driver to mongodb-driver-legacy:5.4.0 #34100

Uh oh!

Conversation

jyemin commented Feb 27, 2025

GitHub Actions Tests Status (on master branch)

Uh oh!

jyemin Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 27, 2025

Uh oh!

jyemin Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

derrickaw commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

jyemin commented Mar 18, 2025

Uh oh!

Abacn commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

jyemin commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jyemin commented Mar 26, 2025

Uh oh!

Abacn commented Mar 26, 2025

Uh oh!

jyemin commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 9, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

damccorm commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

chamikaramj commented Jun 20, 2025

Uh oh!

derrickaw commented Aug 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jyemin commented Mar 26, 2025 •

edited

Loading