Skip to content

Conversation

@scwhittle
Copy link
Contributor

Previously reportProgress could cache a reader for the initialRestriction of a source that was unstarted. If this was used for a subsequent read it could happen that the source is advanced and checkpointed without having start called.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Mar 3, 2025
…reader.

Previously reportProgress could cache a reader for the initialRestriction of a
source that was unstarted. If this was used for a subsequent read it could
happen that the source is advanced and checkpointed without having start called.

Also improve to close() during errors in getProgress similar to tryClaim
@scwhittle scwhittle force-pushed the start_before_split branch from ae32e02 to 5185a66 Compare March 3, 2025 13:20
@liferoad liferoad requested a review from kennknowles March 3, 2025 14:30
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@scwhittle
Copy link
Contributor Author

Run Java PreCommit

@scwhittle
Copy link
Contributor Author

Run Java_GCP_IO_Direct PreCommit

@scwhittle
Copy link
Contributor Author

Run Java_IOs_Direct PreCommit

@scwhittle
Copy link
Contributor Author

Run Java_Amazon-Web-Services2_IO_Direct PreCommit

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (ac1c788) to head (5185a66).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34146      +/-   ##
============================================
+ Coverage     57.75%   59.33%   +1.58%     
- Complexity     1474     3282    +1808     
============================================
  Files           995     1166     +171     
  Lines        157686   178702   +21016     
  Branches       1076     3396    +2320     
============================================
+ Hits          91064   106041   +14977     
- Misses        64376    69256    +4880     
- Partials       2246     3405    +1159     
Flag Coverage Δ
java 70.51% <ø> (+1.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scwhittle
Copy link
Contributor Author

Run Java PreCommit

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@scwhittle scwhittle merged commit ed8b1f7 into apache:master Mar 4, 2025
28 checks passed
@scwhittle scwhittle deleted the start_before_split branch March 4, 2025 19:36
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
…reader. (apache#34146)

Previously reportProgress could cache a reader for the initialRestriction of a
source that was unstarted. If this was used for a subsequent read it could
happen that the source is advanced and checkpointed without having start called.

Also improve to close() during errors in getProgress similar to tryClaim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants