-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Java] Fix UnboundedReaderAsSdfFn to avoid using unstarted unbounded reader. #34146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…reader. Previously reportProgress could cache a reader for the initialRestriction of a source that was unstarted. If this was used for a subsequent read it could happen that the source is advanced and checkpointed without having start called. Also improve to close() during errors in getProgress similar to tryClaim
ae32e02 to
5185a66
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Run Java PreCommit |
|
Run Java_GCP_IO_Direct PreCommit |
|
Run Java_IOs_Direct PreCommit |
|
Run Java_Amazon-Web-Services2_IO_Direct PreCommit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34146 +/- ##
============================================
+ Coverage 57.75% 59.33% +1.58%
- Complexity 1474 3282 +1808
============================================
Files 995 1166 +171
Lines 157686 178702 +21016
Branches 1076 3396 +2320
============================================
+ Hits 91064 106041 +14977
- Misses 64376 69256 +4880
- Partials 2246 3405 +1159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Run Java PreCommit |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
…reader. (apache#34146) Previously reportProgress could cache a reader for the initialRestriction of a source that was unstarted. If this was used for a subsequent read it could happen that the source is advanced and checkpointed without having start called. Also improve to close() during errors in getProgress similar to tryClaim
Previously reportProgress could cache a reader for the initialRestriction of a source that was unstarted. If this was used for a subsequent read it could happen that the source is advanced and checkpointed without having start called.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.