Skip to content

Conversation

@shunping
Copy link
Collaborator

  • Move threshold dofn to transforms.py so all DoFns and auxiliary transforms are in one place.
  • Add constants for default normal/outlier/missing labels.
  • Add docstrings for some specifiable functions.

depends on #34232 and #34234

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping shunping force-pushed the anomaly-detection-4-3 branch 2 times, most recently from d1627a5 to 0be6acf Compare March 10, 2025 19:40
@shunping
Copy link
Collaborator Author

r: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping shunping force-pushed the anomaly-detection-4-3 branch from 0be6acf to 7478513 Compare March 11, 2025 01:07
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, lets wait until #34234 is in/we can rebase against master since this pulls in changes from that PR as well.

@shunping shunping force-pushed the anomaly-detection-4-3 branch from 7478513 to b73ae8a Compare March 11, 2025 23:43
@shunping shunping force-pushed the anomaly-detection-4-3 branch from b73ae8a to 8b89095 Compare March 12, 2025 00:45
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.35%. Comparing base (5d38b8e) to head (8b89095).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/ml/anomaly/transforms.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34235      +/-   ##
============================================
+ Coverage     56.32%   56.35%   +0.03%     
  Complexity     3286     3286              
============================================
  Files          1172     1173       +1     
  Lines        178933   179045     +112     
  Branches       3398     3398              
============================================
+ Hits         100778   100895     +117     
+ Misses        74898    74893       -5     
  Partials       3257     3257              
Flag Coverage Δ
python 81.33% <97.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 7471411 into apache:master Mar 12, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants