-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[AnomalyDetection] Refactor code and add more docstrings #34235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
d1627a5 to
0be6acf
Compare
|
r: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
0be6acf to
7478513
Compare
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, lets wait until #34234 is in/we can rebase against master since this pulls in changes from that PR as well.
7478513 to
b73ae8a
Compare
b73ae8a to
8b89095
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34235 +/- ##
============================================
+ Coverage 56.32% 56.35% +0.03%
Complexity 3286 3286
============================================
Files 1172 1173 +1
Lines 178933 179045 +112
Branches 3398 3398
============================================
+ Hits 100778 100895 +117
+ Misses 74898 74893 -5
Partials 3257 3257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
depends on #34232 and #34234