[BEAM-2503] use static table name in BeamSql.simpleQuery #3427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takidau
approved these changes
Jun 27, 2017
Contributor
takidau
left a comment
takidau
left a comment
There was a problem hiding this comment.
LGTM. Thank you! I'll go ahead and merge.
| public PCollection<BeamSqlRow> expand(PCollection<BeamSqlRow> input) { | ||
| // public SimpleQueryTransform withUdf(String udfName){ | ||
| // throw new UnsupportedOperationException("Pending for UDF support"); | ||
| // } |
Contributor
There was a problem hiding this comment.
Best not to check in commented-out code. Since I have no other requests for changes, I'll remove as part of merging.
Contributor
|
Merged. Forgot to remove the commented out code. If it's not getting uncommented the next time you edit this file, let's please remove it then. Feel free to close this PR. |
Author
Contributor
|
For a feature branch I think that's probably okay, but I wouldn't want to leave commented-out code lying around on master. Thanks! Feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @takidau
As discussed in #3372, here's the part to use fixed table name
PCOLLECTIONinBeamSql.simpleQuery.