Skip to content

Conversation

@twosom
Copy link
Contributor

@twosom twosom commented Mar 13, 2025

Please add a meaningful description for your change here

fixes #20426

This PR addresses an issue in the translateImpulse method of the SparkStreamingPortablePipelineTranslator, which was introduced in the changes made under #34080.

The root cause of the test failures was the use of ConstantInputDStream instead of SingleEmitInputDStream. This incorrect implementation led to the impulse being emitted multiple times, causing unexpected behavior.

By replacing ConstantInputDStream with SingleEmitInputDStream, this issue has been resolved.

related PR : #34253


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Mar 13, 2025
@twosom
Copy link
Contributor Author

twosom commented Mar 13, 2025

Run Java PreCommit

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@twosom
Copy link
Contributor Author

twosom commented Mar 13, 2025

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quick fix!

btw, would you mind add a statement in https://github.com/apache/beam/blob/master/CHANGES.md#2640---unreleased to note the Spark runner improvement made here and in #34080 ?

@Abacn
Copy link
Contributor

Abacn commented Mar 13, 2025

Java Tests failed at uploading logs, infra flakiness, not related to the change

@Abacn Abacn merged commit bdb2693 into apache:master Mar 13, 2025
15 of 16 checks passed
@twosom
Copy link
Contributor Author

twosom commented Mar 14, 2025

Thank you for quick fix!

btw, would you mind add a statement in https://github.com/apache/beam/blob/master/CHANGES.md#2640---unreleased to note the Spark runner improvement made here and in #34080 ?

Thank you for pointing that out!

I completely forgot to update the CHANGES.md with the changes. I'll make sure to add the note regarding the Spark runner improvement made here and in #34080. Let me update it and create a pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for checkpointing in Spark streaming

2 participants