[AnomalyDetection] Support functions and classes as init arguments in specifiable. #34273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunping
changed the title
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
|
Oh, please fix linting though |
Collaborator
Author
Fixed. Waiting for the tests to finish. |
shunping
force-pushed
the
anomaly-detection-5-1
branch
from
ae440b5 to
8b0d135
Compare
Collaborator
Author
@damccorm, the tests are fine now. PTAL. Thanks! |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we will now support generating Spec for a specifiable initialized with classes or functions as init arguments.
In addition, re-registering a spec_type with the same class is now allowed. Trying to override with a different class will still lead to an exception though.