-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Expose add-modules JVM option in SDKHarnessOptions #34289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested on Dataflow v2 + Java 21 with a pipeline uses "jdk.incubator.vector" Beam 2.63.0 (job Id with this change (build java core locally, build a custom container, add pipeline option |
|
R: @kennknowles |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
also worked for Dataflow legacy runner (after internal change) job id: |
|
R: @tvalentyn (internal tracker: b/337016101) |
tvalentyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
|
(Updated pr description) |
|
failed Dataflow worker test:
not related to the change |
* Expose add-modules JVM option in SDKHarnessOptions * add changes.md * Update CHANGES.md Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com> * Fix whitespace * fix whitespace --------- Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
Adds support for
--add-modulesJVM option through a new pipeline optionJdkAddRootModulesfixes: #30281
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.