-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[1/2] sdks/python: enrich data with CloudSQL [PostgreSQL, MySQL, SQLServer] #34398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3fa2360 to
38101e4
Compare
2f7a11d to
6cf8952
Compare
|
Hi @claudevdm, I think the PR is now ready for review. I’ve run all test cases locally, including the integration tests, and they pass since I’m using a PostgreSQL Cloud SQL managed instance in my Google Cloud for testing. However, the integration tests currently fail in the CI pipeline because there’s no Cloud SQL testing instance to connect to. It seems like this may require additional setup or administration. How am I supposed to move this PR forward? Thanks! |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thank you for your contribution to the Cloud SQL Enrichment Handler. I'd like to share some thoughts about potential improvements:
Could @liferoad and @svetakvsundhar share their thoughts on the user interface design and SQLAlchemy integration? |
|
waiting on author |
aa9b2e7 to
eb3a110
Compare
It seems there are issues with the CI. Close and reopen this PR to re-trigger it. |
|
Hi @claudevdm, I've addressed the SQL injection issue as per this comment #34398 (comment). I think this PR is now ready for review and I would love to receive any feedback on it 🙇♂️ |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
|
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is excellent - I just had one question, otherwise we can go ahead and merge
|
Triggering again the postcommits now... |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Confirmed remaining tests are flakes
Description
Towards #30773.
Towards #35046.
Next #35473.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.