Skip to content

Conversation

@mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Mar 24, 2025

Description

  • Add Google CloudSQL Enrichment Handler
  • Support Enrichment for Unmanaged PostgreSQL
  • Support Enrichment for Unmanaged MySQL
  • Support Enrichment for Unmanaged Microsoft SQL Server
  • Unit Test Google CloudSQL Enrichment Handler
  • Integrate Test Google CloudSQL Enrichment Handler
  • Add Release Note for the new Google CloudSQL Enrichment Handler Integration

Towards #30773.
Towards #35046.
Next #35473.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad liferoad requested a review from claudevdm March 25, 2025 15:20
@mohamedawnallah mohamedawnallah force-pushed the enrichWithCloudSQL branch 6 times, most recently from 2f7a11d to 6cf8952 Compare March 25, 2025 22:29
@mohamedawnallah mohamedawnallah marked this pull request as ready for review March 25, 2025 23:01
@mohamedawnallah
Copy link
Contributor Author

Hi @claudevdm,

I think the PR is now ready for review. I’ve run all test cases locally, including the integration tests, and they pass since I’m using a PostgreSQL Cloud SQL managed instance in my Google Cloud for testing.

However, the integration tests currently fail in the CI pipeline because there’s no Cloud SQL testing instance to connect to. It seems like this may require additional setup or administration.

How am I supposed to move this PR forward?

Thanks!

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@mohamedawnallah
Copy link
Contributor Author

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @damccorm for label website.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@claudevdm
Copy link
Collaborator

Thank you for your contribution to the Cloud SQL Enrichment Handler. I'd like to share some thoughts about potential improvements:

  • Query Flexibility: We should consider expanding the interface to allow users to:

    1. Select specific columns rather than always returning all columns
    2. Apply multiple filtering conditions (e.g., filtering on both customer_id AND region)
    3. Support more complex query conditions beyond simple equality checks
  • SQLAlchemy Integration: Given that we're supporting three different database types (MySQL, PostgreSQL, and SQL Server), leveraging SQLAlchemy would:

    1. Provide database-agnostic query building
    2. Handle dialect-specific syntax differences automatically
    3. Offer better protection against SQL injection vulnerabilities
  • Batch Processing Support: For performance optimization, we should implement batched queries similar to the BigQuery handler

    def __call__(self, request: Union[beam.Row, list[beam.Row]], *args, **kwargs):

Could @liferoad and @svetakvsundhar share their thoughts on the user interface design and SQLAlchemy integration?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Reminder, please take a look at this pr: @liferoad @damccorm

@damccorm
Copy link
Contributor

damccorm commented Apr 3, 2025

waiting on author

@mohamedawnallah
Copy link
Contributor Author

Installed distributions
Trying to resolve the latest version from remote

It seems there are issues with the CI. Close and reopen this PR to re-trigger it.

@github-actions github-actions bot added build and removed build labels Aug 3, 2025
@github-actions github-actions bot added build and removed build labels Aug 3, 2025
@mohamedawnallah
Copy link
Contributor Author

Hi @claudevdm, I've addressed the SQL injection issue as per this comment #34398 (comment). I think this PR is now ready for review and I would love to receive any feedback on it 🙇‍♂️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.
R: @melap for label website.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@derrickaw
Copy link
Collaborator

Hi @shunping and @melap, please review when you get a chance. Thanks!

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is excellent - I just had one question, otherwise we can go ahead and merge

@github-actions github-actions bot added build and removed build labels Aug 15, 2025
@github-actions github-actions bot added build and removed build labels Aug 16, 2025
@mohamedawnallah
Copy link
Contributor Author

Triggering again the postcommits now...

@github-actions github-actions bot added build and removed build labels Aug 20, 2025
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Confirmed remaining tests are flakes

@damccorm damccorm merged commit 3e59ea9 into apache:master Aug 22, 2025
105 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants