Skip to content

[BEAM-124] Flink and Spark running Examples WordCountIT #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasonkuster wants to merge 1 commit into from
Closed

[BEAM-124] Flink and Spark running Examples WordCountIT #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions examples/java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,30 @@
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>org.apache.beam</groupId>
<artifactId>flink-runner_2.10</artifactId>
<version>${project.version}</version>
</dependency>

<dependency>
Copy link
Member

@amitsela amitsela May 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the Spark dependencies are here because they are provided in the runner and therefore they are not transitive. I'm afraid this will cause the examples pom to be a bit "busy" as more runners join...

Copy link
Member

@davorbonaci davorbonaci May 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a minimum, these should be optional, runtime deps only.
+1 to everything Amit said.

<groupId>org.apache.spark</groupId>
<artifactId>spark-core_2.10</artifactId>
<version>1.6.1</version>
</dependency>

<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-streaming_2.10</artifactId>
<version>1.6.1</version>
</dependency>

<dependency>
<groupId>org.apache.beam</groupId>
<artifactId>spark-runner</artifactId>
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client</artifactId>
Expand Down
11 changes: 0 additions & 11 deletions runners/flink/runner/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,6 @@
</dependency>

<!-- Test scoped -->
<dependency>
<groupId>org.apache.beam</groupId>
<artifactId>java-examples-all</artifactId>
<exclusions>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-jdk14</artifactId>
</exclusion>
</exclusions>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_2.10</artifactId>
Expand Down
80 changes: 0 additions & 80 deletions runners/flink/runner/src/test/java/org/apache/beam/runners/flink/TfIdfITCase.java
View file
Open in desktop

This file was deleted.

77 changes: 0 additions & 77 deletions runners/flink/runner/src/test/java/org/apache/beam/runners/flink/WordCountITCase.java
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions runners/spark/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.beam</groupId>
<artifactId>java-examples-all</artifactId>
<exclusions>
<!-- Use Hadoop/Spark's backend logger -->
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-jdk14</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro-mapred</artifactId>
Expand Down
Loading