Skip to content

Conversation

@DKER2
Copy link
Contributor

@DKER2 DKER2 commented Apr 4, 2025

fixes #34438

Revert #30770 as we already has permanent fix #34354. #30770 is a workaround to avoid negative value in https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java#L103-L109


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.82%. Comparing base (160dffd) to head (c59ba99).
Report is 1338 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34542      +/-   ##
============================================
+ Coverage     57.32%   57.82%   +0.49%     
  Complexity     1474     1474              
============================================
  Files           967     1004      +37     
  Lines        153754   157785    +4031     
  Branches       1076     1076              
============================================
+ Hits          88140    91233    +3093     
- Misses        63410    64348     +938     
  Partials       2204     2204              
Flag Coverage Δ
python 81.15% <100.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @claudevdm for label python.
R: @m-trieu for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added java and removed java labels Apr 9, 2025
@Abacn Abacn merged commit 7136380 into apache:master Apr 9, 2025
90 checks passed
@Abacn
Copy link
Contributor

Abacn commented Apr 9, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: avro_dict_to_beam_row negative integer incorrectly converts to uint

3 participants