-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Bug]: avro_dict_to_beam_row negative integer incorrectly converts to uint #34542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34542 +/- ##
============================================
+ Coverage 57.32% 57.82% +0.49%
Complexity 1474 1474
============================================
Files 967 1004 +37
Lines 153754 157785 +4031
Branches 1076 1076
============================================
+ Hits 88140 91233 +3093
- Misses 63410 64348 +938
Partials 2204 2204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Assigning reviewers. If you would like to opt out of this review, comment R: @claudevdm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This reverts commit 2f01a26.
|
Thank you! |
fixes #34438
Revert #30770 as we already has permanent fix #34354. #30770 is a workaround to avoid negative value in https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/VarInt.java#L103-L109
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.