-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Spark Runner : Support for Streaming side-inputs for Spark Runner #34560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark Runner : Support for Streaming side-inputs for Spark Runner #34560
Conversation
|
It is important to note one key aspect before proceeding. In Spark Runner, PCollectionView inherently utilizes Broadcast variables. As a result, it is not considered a checkpoint target. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
There are something flaky tests. I'll fix it. |
f13a840 to
60220a9
Compare
8f9951c to
ea50052
Compare
|
The existing test |
6c4f756 to
c78bf3d
Compare
c78bf3d to
2072db6
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @chamikaramj added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @chamikaramj |
|
Hello, could you please review this PR? |
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkTransformOverrides.java
Outdated
Show resolved
Hide resolved
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkPCollectionView.java
Outdated
Show resolved
Hide resolved
runners/spark/src/main/java/org/apache/beam/runners/spark/util/SideInputReaderUtils.java
Outdated
Show resolved
Hide resolved
runners/spark/src/main/java/org/apache/beam/runners/spark/util/SparkSideInputReader.java
Show resolved
Hide resolved
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @chamikaramj added as fallback since no labels match configuration Available commands:
|
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please add a meaningful description for your change here
fixes #18136
This PR implements streaming side-inputs support in the Spark runner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.