Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Apr 10, 2025

fixes #32636

Inspired by #34348 (comment) and some offline discussions with @lostluck.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lostluck
Copy link
Contributor

We need to also un-skip the packed coders test in Python with this PR. Basically delete the overload test_pack_combiners here: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/prism_runner_test.py#L220

@github-actions github-actions bot added python and removed python labels Apr 10, 2025
@shunping
Copy link
Collaborator Author

We need to also un-skip the packed coders test in Python with this PR. Basically delete the overload test_pack_combiners here: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/prism_runner_test.py#L220

Done.

@lostluck
Copy link
Contributor

Confirmed that test_pack_combiners runs and succeeds! The current failure seems like an unrelated flake, but we should re-run that to be sure, before merging in.

@lostluck lostluck merged commit 05e939e into apache:master Apr 11, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[prism] Python Validates Runner (test_pack_combiners) - Unknown Coder not being processed (tuple)

2 participants