Skip to content

Conversation

@derrickaw
Copy link
Collaborator

@derrickaw derrickaw commented Apr 21, 2025

Phase 1 of this document - https://s.apache.org/beam-yaml-it
#34611


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@derrickaw derrickaw changed the title Phase 1 - more yaml integration tests Phase 1sh - more yaml integration tests Apr 21, 2025
@github-actions github-actions bot added the build label Apr 21, 2025
@derrickaw derrickaw force-pushed the stage1YamlIntegrationTests branch from 8756e77 to 0a32118 Compare April 22, 2025 16:37
@derrickaw
Copy link
Collaborator Author

The PreCommit YAML Xlang Direct check is failing due to a tensorflow_transform missing package. We added a few changes to allow a parameter pass through to enable the needed packages during the workflow. This was verified locally by running ./gradlew :sdks:python:yamlIntegrationTests -PbeamPythonExtra=ml_test and all integration tests passed. This github action will pass after the PR is merged.

@derrickaw derrickaw marked this pull request as ready for review April 22, 2025 20:51
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Apr 23, 2025

CI failing due to .github/workflow change not effective on PR run. The test could pass locally feeding same gradle command, merging for now

uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:yamlIntegrationTests
gradle-command: :sdks:python:yamlIntegrationTests -PbeamPythonExtra=ml_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we add more tests, it may worth split out the workflow and create a "PreCommit YAML Xlang" exercises more tests on postsubmit schedule, to keep presubmit run on reasonable time. Could be a follow up

- type: AssertEqual
config:
elements:
- {label: "11a", rank: 0, timestamp: Timestamp(-9223372036854.775000), window_start: Timestamp(-9223372036854.775000), window_end: Timestamp(9223371950454.775000)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global window is default. The min / max timestamp of global window is also internal implementation detail (?). Consider assign a fixed window then assert (could be follow up)

@Abacn Abacn merged commit 5c4b42f into apache:master Apr 23, 2025
103 of 105 checks passed
@derrickaw derrickaw deleted the stage1YamlIntegrationTests branch April 23, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants