-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Use Java 17 for Debezium IO #34747 #34751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
So it cannot support Java 11 or Java 8? Note we still have many users for Java 11 and 8. |
|
@liferoad no, it unfortunately can't, see here: https://debezium.io/releases/3.0/release-notes#breaking_changes_14 |
|
The problem is that:
|
|
I am fine if we decide this breaking change is needed for Debezium IO to only support Java 17+. Looks like https://github.com/GoogleCloudPlatform/DataflowTemplates does not use this IO directly. |
CHANGES.md
Outdated
| ## I/Os | ||
| * Support for X source added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)). | ||
| * Debezium IO now requires Java 17 (Java) ([#34747](https://github.com/apache/beam/issues/34747)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change alone does not affect artifact build yet. We can defer the announcement after Debezium client version upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abacn Thank you! Reverted
| with: | ||
| java-version: | | ||
| 17 | ||
| 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now use Java 11 to build Beam (with Java 8 byte code compatibility). So change 8 -> 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Adjusted to 11
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Check in CI change is fine and it would facilitate PR developement.
Use Java 11 not 8 as fallback, according to review by @Abacn
This is step 1 for issue #34747 to get to a newer Debezium IO version in Beam, as Debezium requires Java 17 or later with version 3.0 (or later). I tested the local build with gradle and Java 17 before making this change for the build system.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.