Skip to content

Conversation

@shunping
Copy link
Collaborator

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

elmBytes: nil, // indicates this is a timer.
keyBytes: keyBytes,
window: w,
sequence: -1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here saying "indicates this timer is being cleared". Also go to definition for the element struct definition, so we can update the documentation for the sequence about this usage of it: a value of -1 means this is a timer that should be cleared... etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@shunping
Copy link
Collaborator Author

Looking into the only failed test: PrismRunnerTest.test_pardo_timers_clear

@shunping shunping force-pushed the prism-timer-clear branch from 6722b60 to 136b504 Compare May 31, 2025 01:13
@lostluck lostluck marked this pull request as ready for review May 31, 2025 01:45
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if you want me to look at anything else.

This is a very good find.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @lostluck for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping
Copy link
Collaborator Author

Thanks so much for reviewing this, @lostluck.

I will merge this first and work on a PR with the tests next.

@shunping shunping merged commit f9dca88 into apache:master May 31, 2025
10 checks passed
@shunping shunping changed the title Fix the issue of timer clearing not working across bundle Prism: Fix the issue of timer clearing not working across bundle Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants