Skip to content

Fix PostCommit Python Xlang IO Dataflow job #35131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 2 commits into from
Jun 3, 2025
Merged

Fix PostCommit Python Xlang IO Dataflow job #35131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa39d9e
Add support for iterable type
Amar3tto Jun 2, 2025
6525c51
Fix formatting
Amar3tto Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdks/python/apache_beam/coders/row_coder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ def _nonnull_coder_from_type(field_type):
return BytesCoder()
elif type_info == "array_type":
return IterableCoder(_coder_from_type(field_type.array_type.element_type))
elif type_info == "iterable_type":
return IterableCoder(
_coder_from_type(field_type.iterable_type.element_type))
elif type_info == "map_type":
return MapCoder(
_coder_from_type(field_type.map_type.key_type),
Expand Down
4 changes: 4 additions & 0 deletions sdks/python/apache_beam/typehints/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,10 @@ def typing_from_runner_api(
return LogicalType.from_runner_api(
fieldtype_proto.logical_type).language_type()

elif type_info == "iterable_type":
return Sequence[self.typing_from_runner_api(
fieldtype_proto.iterable_type.element_type)]

else:
raise ValueError(f"Unrecognized type_info: {type_info!r}")

Expand Down
Loading