Skip to content

Fix Playground CI Nightly job #35149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Amar3tto wants to merge 2 commits into from
Closed

Fix Playground CI Nightly job #35149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48b849e
Fix Sql examples for playground
Amar3tto Jun 4, 2025
2bfc798
Remove redundant dependencies
Amar3tto Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,6 @@ tasks.register("javaPreCommit") {
dependsOn(":beam-validate-runner:build")
dependsOn(":examples:java:build")
dependsOn(":examples:java:preCommit")
dependsOn(":examples:java:sql:build")
Copy link
Contributor

@Abacn Abacn Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This separate module was intended: #34322 (comment)

I try to avoid sql dependencies in main example. Any chance make the CI work with separate module?

Copy link
Collaborator Author

@Amar3tto Amar3tto Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here: #35183

dependsOn(":examples:java:sql:preCommit")
dependsOn(":examples:java:twitter:build")
dependsOn(":examples:java:twitter:preCommit")
dependsOn(":examples:multi-language:build")
Expand Down
1 change: 1 addition & 0 deletions examples/java/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ dependencies {
implementation project(":sdks:java:extensions:avro")
implementation project(":sdks:java:extensions:google-cloud-platform-core")
implementation project(":sdks:java:extensions:python")
implementation project(":sdks:java:extensions:sql")
implementation project(":sdks:java:io:google-cloud-platform")
implementation project(":sdks:java:io:kafka")
runtimeOnly project(":sdks:java:io:iceberg")
Expand Down
51 changes: 0 additions & 51 deletions examples/java/sql/README.md
View file
Open in desktop

This file was deleted.

122 changes: 0 additions & 122 deletions examples/java/sql/build.gradle
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .../examples/sql/SchemaTransformExample.java → ...beam/examples/SchemaTransformExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.beam.examples.sql;
package org.apache.beam.examples;

// beam-playground:
// name: Group.ByFields
// name: SchemaTransformGroupByFields
// description: Demonstration of Schema transform usage.
// multifile: false
// default_example: false
Expand Down
2 changes: 1 addition & 1 deletion ...eam/examples/sql/SqlTransformExample.java → ...he/beam/examples/SqlTransformExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.beam.examples.sql;
package org.apache.beam.examples;

// beam-playground:
// name: SqlTransform
Expand Down
1 change: 0 additions & 1 deletion settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ include(":examples:java:cdap:hubspot")
include(":examples:java:cdap:salesforce")
include(":examples:java:cdap:servicenow")
include(":examples:java:cdap:zendesk")
include(":examples:java:sql")
include(":examples:java:webapis")
include(":examples:kotlin")
include(":examples:multi-language")
Expand Down
Loading