Skip to content

Conversation

@kennknowles
Copy link
Member

The following mostly-automated changes:

  • Moved WindowedValue from internal-only util to public values package
  • Make WindowedValue an interface with companion class WindowedValues

This is an initial step to #34902 that touches lots of lines and files but is largely automated and has no interesting content. Separating this for ease of review.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@kennknowles
Copy link
Member Author

R: @ahmedabu98 or @stankiewicz

If you wouldn't mind just scrolling through and convincing yourself I didn't make any nontrivial change.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@kennknowles kennknowles force-pushed the WindowedValue branch 2 times, most recently from 8560e4c to 7904ba3 Compare June 5, 2025 02:17
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (60307b4) to head (7904ba3).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #35159   +/-   ##
=========================================
  Coverage     56.44%   56.44%           
- Complexity     3299     3300    +1     
=========================================
  Files          1185     1185           
  Lines        181910   181915    +5     
  Branches       3409     3409           
=========================================
+ Hits         102682   102689    +7     
+ Misses        75959    75958    -1     
+ Partials       3269     3268    -1     
Flag Coverage Δ
java 70.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@stankiewicz stankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValue.java
and sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValues.java
and skimmed through most of the small changes. .

@kennknowles
Copy link
Member Author

Thanks! Fixing up some reflective access in the SparkRunner before I merge.

The following mostly-automated changes:

 - Moved WindowedValue from util to values package
 - Make WindowedValue an interface with companion class WindowedValues
@kennknowles
Copy link
Member Author

Dataflow Streaming PipelineTest I looked at job https://console.cloud.google.com/dataflow/jobs/us-central1/2025-06-05_12_06_25-3244368481778048427 and it did not have any error. It did look like it was in a weird state, but had
image and also so many other jobs succeeded I don't think it means anything. It takes 7 hours so deflaking is not practical.

@kennknowles kennknowles merged commit acafd37 into apache:master Jun 6, 2025
35 of 37 checks passed
@kennknowles kennknowles deleted the WindowedValue branch June 6, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants