Skip to content

[Java FnApi] Fix race in BeamFnStatusClient by initializing all fields before starting rpc. #35252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 2 commits into from
Jun 12, 2025
Merged

[Java FnApi] Fix race in BeamFnStatusClient by initializing all fields before starting rpc. #35252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3854f4
[Java FnApi] Fix race in BeamFnStatusClient by initializing all field…
scwhittle Jun 12, 2025
71629c6
spotless
scwhittle Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdks/java/harness/src/main/java/org/apache/beam/fn/harness/status/BeamFnStatusClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ public BeamFnStatusClient(
PipelineOptions options,
Cache<?, ?> cache) {
this.channel = channelFactory.apply(apiServiceDescriptor);
this.outboundObserver =
BeamFnWorkerStatusGrpc.newStub(channel).workerStatus(new InboundObserver());
this.processBundleCache = processBundleCache;
this.memoryMonitor = MemoryMonitor.fromOptions(options);
this.cache = cache;
Expand All @@ -76,6 +74,11 @@ public BeamFnStatusClient(
thread.setPriority(Thread.MIN_PRIORITY);
thread.setName("MemoryMonitor");
thread.start();

// Start the rpc after all the initialization is complete as the InboundObserver
// may be called any time after this.
this.outboundObserver =
BeamFnWorkerStatusGrpc.newStub(channel).workerStatus(new InboundObserver());
}

@Override
Expand Down
Loading