-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Support runners other than DirectRunner for :examples:java:execute #35262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested with |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Looks like the last successful run is three days ago. |
|
Trying to revert the first red master run (https://github.com/apache/beam/actions/runs/15566528898). Let's see if the check can pass with this. |
latest run there is a single prism runner test failing, not related to this change PTAL @shunping |
|
Given the previous failed Java PreCommit tests on prism have been fixed at #35336, I think it is safe to LGTM here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35262 +/- ##
=========================================
Coverage 54.50% 54.50%
Complexity 1479 1479
=========================================
Files 1017 1017
Lines 160983 160983
Branches 1079 1079
=========================================
Hits 87737 87737
Misses 71140 71140
Partials 2106 2106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.