-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch #35271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results15 tests 15 ✅ 1h 46m 28s ⏱️ Results for commit f1935a7. |
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@ahmedabu98 Could you please take a look at the failed Iceberg checks? |
|
@Amar3tto I checked the Dataflow pipelines. The tests on master are pulling the SDK container image from Dataflow tests on this PR are pulling from The difference reflects this change: 086ae6c My guess is the Dataflow container just hasn't been built and uploaded to that location yet |
|
"NOTE Dataflow tests will fail if the Dataflow worker container is not created and published by this time. Should be done by Google, in response to the creation of the release branch, and docker images are hosted. This should not block creation of the first release candidate, but should block approval of the release." |
|
@Amar3tto I'd recommend that you go ahead and create the first RC. At that point, I can publish the Dataflow containers needed to make this pass. |
|
Hmmm I see that the other Dataflow tests are passing because they first build and publish a new container image to use for the test, e.g.: beam/runners/google-cloud-dataflow-java/build.gradle Lines 712 to 714 in 19ff1df
Iceberg Dataflow tests are missing this step. |
|
Adding it in #35307 |
|
Reminder, please take a look at this pr: @damccorm |
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
Tests run on GHA should be queued shortly.