Skip to content

Conversation

@Amar3tto
Copy link
Collaborator

Tests run on GHA should be queued shortly.

@github-actions github-actions bot added the build label Jun 13, 2025
@github-actions
Copy link
Contributor

Test Results

15 tests   15 ✅  1h 46m 28s ⏱️
12 suites   0 💤
12 files     0 ❌

Results for commit f1935a7.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto
Copy link
Collaborator Author

@ahmedabu98 Could you please take a look at the failed Iceberg checks?
I'm not sure why they fail here and succeed on master.

@ahmedabu98
Copy link
Contributor

@Amar3tto I checked the Dataflow pipelines. The tests on master are pulling the SDK container image from --sdk_harness_ids=sdk-0-0,gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:beam-master-20250605 and passing successfully.

Dataflow tests on this PR are pulling from -sdk_harness_ids=sdk-0-0,gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.66.0 and failing with this error:

"PullImage from image service failed" 
err="rpc error: code = NotFound desc = failed to pull and unpack image 
  \"gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.66.0\": 
  failed to resolve reference \"gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.66.0\": 
  gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.66.0: not found" 
image="gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.66.0"

The difference reflects this change: 086ae6c

My guess is the Dataflow container just hasn't been built and uploaded to that location yet

@damccorm
Copy link
Contributor

Yes, see - https://github.com/apache/beam/blob/master/contributor-docs/release-guide.md#verify-release-branch

"NOTE Dataflow tests will fail if the Dataflow worker container is not created and published by this time. Should be done by Google, in response to the creation of the release branch, and docker images are hosted. This should not block creation of the first release candidate, but should block approval of the release."

@damccorm
Copy link
Contributor

@Amar3tto I'd recommend that you go ahead and create the first RC. At that point, I can publish the Dataflow containers needed to make this pass.

@ahmedabu98
Copy link
Contributor

Hmmm I see that the other Dataflow tests are passing because they first build and publish a new container image to use for the test, e.g.:

task examplesJavaRunnerV2PreCommit(type: Test) {
group = "Verification"
dependsOn buildAndPushDockerJavaContainer

Iceberg Dataflow tests are missing this step.

@ahmedabu98
Copy link
Contributor

Adding it in #35307

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @damccorm

@damccorm
Copy link
Contributor

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment assign set of reviewers

@Amar3tto Amar3tto closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants