-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Mysql embeddings #35393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mysql embeddings #35393
Conversation
4b52206 to
f68ee53
Compare
653675c to
a829328
Compare
|
R: @damccorm Sorry for the long PR. I am happy to split it into multiple, maybe?
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - mostly looks good (and very in line with other pieces, which is good)
|
Test failures are related to test containers version change |
Co-authored-by: Danny McCormick <dannymccormick@google.com>
|
This has increased the number of test of https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python_Xlang_Gcp_Dataflow.yml?query=event%3Aschedule from 45 -> 62 causing tests often run exceeds 3h timeout |
|
@Abacn where can I see the list of tests that actually run? I set all of these new tests to be skip on dataflow runner. In the publish test section I see before this change 67 tests found After this change |
|
Actually looking back at the test history, it was timing out a lot before this change too. |
This PR adds a MySQL vector writer implementation following the same pattern as Postgres vector writer.
ColumnSpecsfor specifying howChunkshould be mapped to a MySQL schema andConflictResolutionfor how inserts that violate uniqueness constraints should be handledI tried to strike a balance between maintainability of cloudsql specific dialects by not mixing postgres and mysql language utilities while sharing jdbc common utilities and cloudsql common utilities that do not change depending on the dialect.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.