Skip to content

Conversation

@derrickaw
Copy link
Collaborator

@derrickaw derrickaw commented Jun 24, 2025

#35030 - Phases 3-4

Left to do:


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

R: @jrmccluskey for final approval

@derrickaw
Copy link
Collaborator Author

Failures don't seem related to these changes.

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to give the red test suites one more spin but I do not think those failures are related here

@jrmccluskey
Copy link
Contributor

Looks like the linting problem is in Vertex AI text embeddings, putting a fix out in #35461. Merging this here.

@jrmccluskey jrmccluskey merged commit 6b06823 into apache:master Jun 27, 2025
90 of 92 checks passed
@derrickaw derrickaw deleted the phase34_df2y branch June 27, 2025 15:01
jrmccluskey pushed a commit to jrmccluskey/beam that referenced this pull request Jul 1, 2025
* rebase

* update infra and input data to current

* add phases 3-4 examples

* remove other PR code

* remove other pubsub previous pr code

* add streaming option

* similfy code from previous PR into these code changes

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants