Skip to content

Conversation

@damccorm
Copy link
Contributor

Today, if you compare IntervalWindow(MIN_TIMESTAMP, MAX_TIMESTAMP) and IntervalWindow(MIN_TIMESTAMP - 10, MAX_TIMESTAMP + 10), they are not considered equal, but functionally they are actually equivalent. This is particularly problematic since some portable runners will automatically truncate IntervalWindow(MIN_TIMESTAMP - 10, MAX_TIMESTAMP + 10) to IntervalWindow(MIN_TIMESTAMP, MAX_TIMESTAMP). We can play well with this change by considering these windows to be equal.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

Linting should be fixed by #35463

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @jrmccluskey for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 4d9b436 into master Jul 1, 2025
92 of 95 checks passed
@damccorm damccorm deleted the users/damccorm/iw branch July 1, 2025 14:32
jrmccluskey pushed a commit to jrmccluskey/beam that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants