-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[3/3] sdks/python: enrich data with Milvus Search [Vector, Keyword, Hybrid] #35467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/3] sdks/python: enrich data with Milvus Search [Vector, Keyword, Hybrid] #35467
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
b2323ae to
9525d5f
Compare
…xampleForMilvusHandler
|
Merging the master branch here after this PR #35216 merged |
|
This appears to be the last PR (in a 3-part series) after Apache Beam 2.67.0 to be released, changing the title |
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
perhaps this not supposed to be in review queue yet until Apache Beam 2.67.0 version is released? stopping reviewer notifications |
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
…xampleForMilvusHandler
|
R: @damccorm |
…xampleForMilvusHandler
|
@damccorm –This PR is now ready for review. The precommit python ml test failure is unrelated and seems a transient failure: |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Had some notes, but overall it LGTM
sdks/python/apache_beam/examples/snippets/transforms/elementwise/enrichment_test.py
Show resolved
Hide resolved
website/www/site/content/en/documentation/transforms/python/elementwise/enrichment.md
Show resolved
Hide resolved
…xampleForMilvusHandler
a4886cf to
c764314
Compare
|
When running Milvus tests locally with version I initially tried upgrading the pymilvus client SDK to I resolved the issue by updating the intermediary Milvus daemon YAML file in this commit: b7c064f. This fixed the etcd while still being on version |
14ad6ea to
b7c064f
Compare
|
Thanks a lot @damccorm for the thoughtful review comments. I apologize for the significant delay in addressing them. I've now addressed all of them, and all relevant tests are passing in the CI |
I have tested milvus db versions `v2.6.X` and it's not working given we need to update pymilvus client to match that change as well. Updating pymilvus to `v2.6.X` would cause compatibility beam issues with existing grpc-related packages so it may not be the most feasible upgrade to do in the meantime
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - just had one last question, otherwise LGTM
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Letting checks run, then will merge
Description
Closes #36176.
Towards #35046.
Prev #35577.
Motivation and Context
Follow-up on the discussion here #35216 (comment) and #35216 (comment).
Website Update Demo
website_update_demo.mov
Website Build: https://apache-beam-website-pull-requests.storage.googleapis.com/35467/documentation/transforms/python/elementwise/enrichment-milvus/index.html
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.